Re: Re: [PATCH v10] ufs: core: Add WB buffer resize support
From: Huan Tang
Date: Fri Apr 11 2025 - 05:38:13 EST
> Please remove this attribute again. I don't think that it is useful to
> make the value of wExtendedWriteBoosterSupport available in sysfs.
> Additionally, wExtendedWriteBoosterSupport is a bitfield and hence
> exporting it directly violates the sysfs one-value-per-attribute rule.
>
> Why "general_fail" instead of "general_failure"?
>
> A minor comment: please remove one tab in front of "=" for the value
> assignments in the above array definition.
>
> The formatting of the above code is not compliant with the Linux kernel
> coding style guide. Please reformat this patch, e.g. with "git
> clang-format HEAD^".
>
Hi bart sir,
Thank you for your reply and comments! I have modified it as followsï¼?
https://lore.kernel.org/all/20250411092924.1116-1-tanghuan@xxxxxxxx/
Best wishes to you !
Thanks
Huan