Re: [PATCH net-next v7 07/13] net: pse-pd: Add support for budget evaluation strategies

[Kory Maincent]

On Thu, 10 Apr 2025 14:20:02 +0200
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Hi,
> 
> looks like i started to review it and forgot to send it. Sorry :)

Hello Oleksij,

Thanks for you review and the naming fixes!

> On Tue, Apr 08, 2025 at 04:32:16PM +0200, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx>
> > 
> > This patch introduces the ability to configure the PSE PI budget evaluation
> > strategies. Budget evaluation strategies is utilized by PSE controllers to
> > determine which ports to turn off first in scenarios such as power budget
> > exceedance.
> > 
> > The pis_prio_max value is used to define the maximum priority level
> > supported by the controller. Both the current priority and the maximum
> > priority are exposed to the user through the pse_ethtool_get_status call.
> > +/**
> > + * _pse_pi_enable_sw_pw_ctrl - Enable PSE PI in case of software power
> > control.
> > + *			       Assumes the PSE lock has been acquired
> > + * @pcdev: a pointer to the PSE
> > + * @id: index of the PSE control
> > + * @extack: extack for error reporting
> > + *
> > + * Return: 0 on success and failure value on error
> > + */
> > +static int _pse_pi_enable_sw_pw_ctrl(struct pse_controller_dev *pcdev, int
> > id,
> > +				     struct netlink_ext_ack *extack)
> > +{  
> 
> Is it for "admin enable" or "start power delivery"?

Power delivery. 

I will rename it to: _pse_pi_delivery_power_sw_pw_ctrl

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com