Re: [PATCH 3/3] soc: qcom: socinfo: Add support for new fields in revision 22
From: Konrad Dybcio
Date: Fri Apr 11 2025 - 06:06:41 EST
On 4/11/25 11:50 AM, Mukesh Ojha wrote:
> Add the ncluster_cores_array_offset field with socinfo structure
> revision 22 which specifies no of cores present in each cluster.
>
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> ---
So with all three of your patches, you neither introduce a user for them,
nor even expose them in debugfs.
Please definitely add the latter, and let's talk about the former.
What's 'subpart feture'?
How should we interpret the value added in patch 1? Does it expose the
higher temperature threshold in degrees, or do we need to add some hardcoded
variants for each platform separately?
Konrad