Re: [PATCH v2] asus-laptop: Fix an uninitialized variable

From: Ilpo Järvinen
Date: Fri Apr 11 2025 - 06:15:34 EST


On Thu, 03 Apr 2025 15:26:01 +0300, Denis Arefev wrote:

> The value returned by acpi_evaluate_integer() is not checked,
> but the result is not always successful, so it is necessary to
> add a check of the returned value.
>
> If the result remains negative during three iterations of the loop,
> then the uninitialized variable 'val' will be used in the clamp_val()
> macro, so it must be initialized with the current value of the 'curr'
> variable.
>
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] asus-laptop: Fix an uninitialized variable
commit: 6c683c6887e4addcd6bd1ddce08cafccb0a21e32

--
i.