Re: [PATCH] signal: Update send_signal_locked in relevant comments

[Oleg Nesterov]

On 04/11, jiang.kun2@xxxxxxxxxx wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2252,7 +2252,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
>  			sig = 0;
>  	}
>  	/*
> -	 * Send with __send_signal as si_pid and si_uid are in the
> +	 * Send with __send_signal_locked as si_pid and si_uid are in the
>  	 * parent's namespaces.

Thanks, but I think that today this comment looks confusing either way.
It was added by 61e713bdca3678 along with this

	-               __group_send_sig_info(sig, &info, tsk->parent);
	+               __send_signal(sig, &info, tsk->parent, PIDTYPE_TGID, false);

change.

To me this comment looks outdated, perhaps it would be better to simply
remove it?

Or it should be updated to explain that we use __send_signal_locked()
instead of send_signal_locked() because the latter can wrongly change
si_pid/si_uid...

Oleg.