[PATCH v4 2/2] samples: rust: convert PCI rust sample driver to use try_access_with()
From: Alexandre Courbot
Date: Fri Apr 11 2025 - 08:11:58 EST
This method limits the scope of the revocable guard and is considered
safer to use for most cases, so let's showcase it here.
Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx>
Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
---
samples/rust/rust_driver_pci.rs | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci.rs
index 2bb260aebc9eae24db431238d7d7b48fbad788b4..9ce3a7323a1632e08f833a14c3f49a4218e9a5e6 100644
--- a/samples/rust/rust_driver_pci.rs
+++ b/samples/rust/rust_driver_pci.rs
@@ -83,13 +83,12 @@ fn probe(pdev: &pci::Device<Core>, info: &Self::IdInfo) -> Result<Pin<KBox<Self>
GFP_KERNEL,
)?;
- let bar = drvdata.bar.try_access().ok_or(ENXIO)?;
+ let res = drvdata
+ .bar
+ .try_access_with(|b| Self::testdev(info, b))
+ .ok_or(ENXIO)??;
- dev_info!(
- pdev.as_ref(),
- "pci-testdev data-match count: {}\n",
- Self::testdev(info, &bar)?
- );
+ dev_info!(pdev.as_ref(), "pci-testdev data-match count: {}\n", res);
Ok(drvdata.into())
}
--
2.49.0