Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h

[Borislav Petkov]

On Fri, Apr 11, 2025 at 07:09:56AM -0500, Mario Limonciello wrote:
> I was aiming for a header that we would conceivably use in all these places
> anyway.
> 
> Can you suggest a more fitting existing header?  A new one felt too heavy
> for a single register define.

No, the logic is: put it in the *right* header. Not in the "whatever-works"
header.

So you can easily add a

arch/x86/include/asm/platform.h

header which contains exactly platform stuff. And FCH sounds like a platform
thing to me. Or at least southbridge or whatever that thing is called now. It
certainly ain't part of the CPU so platform should be more fitting.

Unless someone has a better idea...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette