Re: [PATCH v4] net/mlx5: Fix null-ptr-deref in mlx5_create_{inner_,}ttc_table()

From: Markus Elfring
Date: Fri Apr 11 2025 - 10:09:17 EST


> Add NULL check for mlx5_get_flow_namespace() returns in
> mlx5_create_inner_ttc_table() and mlx5_create_ttc_table() to prevent
> NULL pointer dereference.

Can any other summary phrase variants become more desirable accordingly?



> ---
> V3 -> V4: Fix potential memory leak.

* Do you propose to complete the error handling for more function implementations?

* Please avoid duplicate source code.

* Can an other enumeration style become nicer for version numbers?


> V2 -> V3: No functional changes, just gathering the patches in a series.

Would you usually expect more than one update step then?

Regards,
Markus