Re: [PATCH RFC] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()

[Christian Brauner]

On Thu, Apr 10, 2025 at 07:53:03PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> 
> Use KERN_INFO instead of default KERN_NOTICE for
> infof()|info_plog()|infofc() to printk informational messages.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> ---
>  fs/fs_context.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/fs_context.c b/fs/fs_context.c
> index 582d33e8111739402d38dc9fc268e7d14ced3c49..2877d9dec0753a5f03e0a54fa7b8d25072ea7b4d 100644
> --- a/fs/fs_context.c
> +++ b/fs/fs_context.c
> @@ -449,6 +449,10 @@ void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt,
>  			printk(KERN_ERR "%s%s%pV\n", prefix ? prefix : "",
>  						prefix ? ": " : "", &vaf);
>  			break;
> +		case 'i':
> +			printk(KERN_INFO "%s%s%pV\n", prefix ? prefix : "",
> +						prefix ? ": " : "", &vaf);

We can try but it's not out of the question that this might cause users
to complain or cause regressions.

> +			break;
>  		default:
>  			printk(KERN_NOTICE "%s%s%pV\n", prefix ? prefix : "",
>  						prefix ? ": " : "", &vaf);
> 
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250410-rfc_fix_fs-cfa369930abe
> 
> Best regards,
> -- 
> Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>