Re: [PATCH] hwmon: (xgene-hwmon) Simplify PCC shared memory region handling

[Sudeep Holla]

On Fri, Apr 11, 2025 at 07:03:37AM -0700, Guenter Roeck wrote:
> On 4/11/25 04:20, Sudeep Holla wrote:
> > The PCC driver now handles mapping and unmapping of shared memory
> > areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> > this xgene hwmon driver did handling of those mappings like several
> > other PCC mailbox client drivers.
> > 
> > There were redundant operations, leading to unnecessary code. Maintaining
> > the consistency across these driver was harder due to scattered handling
> > of shmem.
> > 
> > Just use the mapped shmem and remove all redundant operations from this
> > driver.
> > 
> > Cc: Jean Delvare <jdelvare@xxxxxxxx>
> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Cc: linux-hwmon@xxxxxxxxxxxxxxx
> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > ---
> >   drivers/hwmon/xgene-hwmon.c | 39 ++++---------------------------------
> >   1 file changed, 4 insertions(+), 35 deletions(-)
> > 
> > Hi,
> > 
> > This is just resend of the same patch that was part of a series [1].
> > Only core PCC mailbox changes were merged during v6.15 merge window.
> > So dropping all the maintainer acks and reposting it so that it can
> 
> Why drop my Ack ? To have me review it again ?
> 

I should have explained why. I assumed you would apply and hence would
sign off anyway. I was just trying to avoid you having to drop that when
applying with some tool. I wasn't expecting you to review again, sorry
for not making that clear.

> FWIW, I had expected that the patch will be picked up with the series.
> 

Yes, me too. But Jassi applied only mailbox changes and I noticed that
only in his pull request.

> Anyway, applied.
> 

Thanks!

-- 
Regards,
Sudeep