Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

[Nico Pache]

On Fri, Apr 11, 2025 at 6:39 AM Richard Fitzgerald
<rf@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On 08/04/2025 10:25 am, Richard Fitzgerald wrote:
> > On 19/03/2025 11:05 pm, Nico Pache wrote:
> >> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
> >> depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
> >> depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling.
> >>
> >> Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file
> >> download")
> >> Signed-off-by: Nico Pache <npache@xxxxxxxxxx>
> >
> > This patch doesn't actually work and breaks kunit.py.
> >
>
> I was working on a series to make the same fixes to another Cirrus
> KUnit test. That series makes the necessary changes to all_tests.config
> so I took the liberty of fixing your patch and including it in
> my series.

Thank you! much appreciated. I will try to apply and test your series
next week.

Sorry, meant to get back to you sooner, I've been very overloaded.

Cheers,
-- Nico
>
> https://lore.kernel.org/linux-kselftest/20250411123608.1676462-1-rf@xxxxxxxxxxxxxxxxxxxxx/T/#t
>