Re: [PATCH v8 05/14] ABI: testing: sysfs-class-oxp: add tt_led attribute documentation

[Ilpo Järvinen]

On Sat, 22 Mar 2025, Antheas Kapenekakis wrote:

> Adds documentation about the tt_led attribute of OneXPlayer devices
> to the sysfs-class-oxp ABI documentation.
> 
> Reviewed-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> Reviewed-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> Signed-off-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
> ---
>  Documentation/ABI/testing/sysfs-platform-oxp | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-platform-oxp b/Documentation/ABI/testing/sysfs-platform-oxp
> index 091269ab2c8c4..ccf8e5902cf86 100644
> --- a/Documentation/ABI/testing/sysfs-platform-oxp
> +++ b/Documentation/ABI/testing/sysfs-platform-oxp
> @@ -11,3 +11,15 @@ Description:
>  		shortcut over the AT keyboard of the device. In addition,
>  		using this setting is a prerequisite for PWM control for most
>  		newer models (otherwise it NOOPs).
> +
> +What:		/sys/devices/platform/<platform>/tt_led
> +Date:		Feb 2025
> +KernelVersion:	6.15

As usual with these versions/dates, this ship has sailed by now.

> +Contact:	"Antheas Kapenekakis" <lkml@xxxxxxxxxxx>
> +Description:
> +		Some OneXPlayer devices (e.g., X1 series) feature a little LED
> +		nested in the Turbo button. This LED is illuminated when the
> +		device is in the higher TDP mode (e.g., 25W). Once tt_toggle
> +		is engaged, this LED is left dangling to its last state. This
> +		attribute allows userspace to control the LED state manually
> +		(either with 1 or 0). Only a subset of devices contain this LED.
> 

-- 
 i.