Re: [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support

[Simon Horman]

On Wed, Apr 09, 2025 at 10:07:57AM +0200, Kory Maincent wrote:
> On Tue, 8 Apr 2025 16:49:34 +0100
> Simon Horman <horms@xxxxxxxxxx> wrote:
> 
> > On Mon, Apr 07, 2025 at 04:03:01PM +0200, Kory Maincent wrote:
> > > From: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> > > 
> > > From: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> > > 
> > > Add PTP basic support for Marvell 88E151x PHYs. These PHYs support
> > > timestamping the egress and ingress of packets, but does not support
> > > any packet modification.
> > > 
> > > The PHYs support hardware pins for providing an external clock for the
> > > TAI counter, and a separate pin that can be used for event capture or
> > > generation of a trigger (either a pulse or periodic).  This code does
> > > not support either of these modes.
> > > 
> > > The driver takes inspiration from the Marvell 88E6xxx DSA and DP83640
> > > drivers.  The hardware is very similar to the implementation found in
> > > the 88E6xxx DSA driver, but the access methods are very different,
> > > although it may be possible to create a library that both can use
> > > along with accessor functions.
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> > > 
> > > Add support for interruption.
> > > Fix L2 PTP encapsulation frame detection.
> > > Fix first PTP timestamp being dropped.
> > > Fix Kconfig to depends on MARVELL_PHY.
> > > Update comments to use kdoc.
> > > 
> > > Co-developed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> > > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>  
> > 
> > Hi Kory,
> > 
> > Some minor feedback from my side.
> > 
> > > ---
> > > 
> > > Russell I don't know which email I should use, so I keep your old SOB.  
> > 
> > Russell's SOB seems to be missing.
> 
> It is, 5 lines higher, but maybe you prefer to have them all together. 

This thread seems to have subsequently gone elsewhere.
But, FTR, yes, I would prefer all tags together.

...