Re: [PATCH v4 2/4] ftrace: Add support for function argument to graph tracer

[Steven Rostedt]

On Fri, 11 Apr 2025 13:02:00 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 2f077d4158e5..718f6e84cc83 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -971,11 +971,10 @@ print_graph_entry_leaf(struct trace_iterator *iter,
>  
>  		if (args_size >= FTRACE_REGS_MAX_ARGS * sizeof(long)) {
>  			print_function_args(s, entry->args, ret_func);
> -			trace_seq_putc(s, ';');
> +			trace_seq_puts(s, ";\n");
>  		} else
> -			trace_seq_puts(s, "();");
> +			trace_seq_puts(s, "();\n");
>  	}
> -	trace_seq_printf(s, "\n");
>  
>  	print_graph_irq(iter, graph_ret->func, TRACE_GRAPH_RET,
>  			cpu, iter->ent->pid, flags);

I changed the patch to have print_graph_retval() simply not add a newline,
and instead just have the caller always print the newline.

I should have never let that function do that. But when it was added, there
wasn't as many options, so it didn't look so bad, so I didn't ask for that
to be changed.

-- Steve