Re: [tip: x86/build] x86/boot: Drop CRC-32 checksum and the build tool that generates it

[Dave Hansen]

On 4/11/25 12:33, Dave Hansen wrote:
...
> The only weird thing I'm doing is booting the kernel with qemu's -kernel
> argument.

I lied. I'm doing other weird things. I have a local script named
"truncate" that's not the same thing as /usr/bin/truncate. Guess what
this patch started doing:

>  quiet_cmd_image = BUILD   $@
> -silent_redirect_image = >/dev/null
> -cmd_image = $(obj)/tools/build $(obj)/setup.bin $(obj)/vmlinux.bin \
> -			       $(obj)/zoffset.h $@ $($(quiet)redirect_image)
> +      cmd_image = cp $< $@; truncate -s %4K $@; cat $(obj)/vmlinux.bin >>$@

				 ^ right there

I'm an idiot. That was a poorly named script and it cost me a kernel
bisect and poking at the patch for an hour. <sigh>

Sorry for the noise.