Re: [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for host-wakeup
From: Rob Herring
Date: Fri Apr 11 2025 - 18:09:55 EST
On Fri, Apr 11, 2025 at 10:07:18PM +0530, Neeraj Sanjay Kale wrote:
> Add support for host-wakeup on GPIO interrupt.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx>
> ---
> .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index d02e9dd847ef..ab1411c05f49 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -48,6 +48,12 @@ properties:
> description:
> The GPIO number of the NXP chipset used for BT_WAKE_IN.
>
> + host-wakeup-gpios:
> + maxItems: 1
> + description:
> + Host wakeup by falling edge interrupt on this GPIO which
> + is connected to BT_WAKE_OUT pin of the NXP chipset.
Read the description in the Broadcom binding you copied this from.
Define this as an interrupt named 'wakeup', not a GPIO. After all, to be
a wake-up source, it kind of has to be an interrupt.
Just because I said no to putting wakeup source handling in serdev,
doesn't mean the binding should change. The handling just has to be in
the driver.
Rob