Re: [PATCH v2 1/5] KVM: selftests: Extract guts of THP accessor to standalone sysfs helpers
From: James Houghton
Date: Fri Apr 11 2025 - 19:14:02 EST
On Fri, Apr 11, 2025 at 2:12 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Mon, Mar 31, 2025, James Houghton wrote:
> > From: Sean Christopherson <seanjc@xxxxxxxxxx>
> >
> > Extract the guts of thp_configured() and get_trans_hugepagesz() to
> > standalone helpers so that the core logic can be reused for other sysfs
> > files, e.g. to query numa_balancing.
> >
> > Opportunistically assert that the initial fscanf() read at least one byte,
> > and add a comment explaining the second call to fscanf().
> >
> > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> > Signed-off-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx>
>
> Needs your SoB. It's a bit absurd for this particular patch, but please provide
> it anyway, if only so that I can get a giggle out of the resulting chain of SoBs :-)
Ah! I meant to include it. I'll repost the v3 with David's change to
patch 3 and my SoB here. Thanks!