Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

[Jacek Kowalski]

> > If this approach is acceptable to you, I will prepare a patch with
> > the proposed fix and send it to you next week for testing on your system.
>
> What solution do you have in mind?
>
> The only one I can think of is to ignore the checksum completely if the
> valid_csum_mask condition is not met on e1000_pch_tgp.

Would you be OK with the following modification:

diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 364378133526..df4e7d781cb1 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -4274,6 +4274,8 @@ static s32 e1000_validate_nvm_checksum_ich8lan(struct e1000_hw *hw)
                        ret_val = e1000e_update_nvm_checksum(hw);
                        if (ret_val)
                                return ret_val;
+               } else if (hw->mac.type == e1000_pch_tgp) {
+                       return 0;
                }
        }
 

?

--
Best regards,
  Jacek Kowalski