Re: [PATCH 6/6] dt-bindings: thermal: sun8i: Add A523 THS0/1 controllers

From: Mikhail Kalashnikov
Date: Fri Apr 11 2025 - 23:50:48 EST


On 4/11/25 04:21, Rob Herring (Arm) wrote:
On Fri, 11 Apr 2025 08:38:26 +0800, iuncuim wrote:
From: Mikhail Kalashnikov <iuncuim@xxxxxxxxx>

Add dt-bindings description of the thermal sensors in the A523 processor.

Signed-off-by: Mikhail Kalashnikov <iuncuim@xxxxxxxxx>
---
.../bindings/thermal/allwinner,sun8i-a83t-ths.yaml | 5 +++++
1 file changed, 5 insertions(+)

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.example.dtb: thermal-sensor@1c25000 (allwinner,sun8i-h3-ths): clock-names:1: 'gpadc' was expected
from schema $id: http://devicetree.org/schemas/thermal/allwinner,sun8i-a83t-ths.yaml#
Thanks for the reply, I didn't know about this tool, I will use it in v2.

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250411003827.782544-7-iuncuim@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
Yes, I forgot to point out that the patches are based on 6.15-rc1 using dts
patches from that series that didn't make it into the latest rc:
https://lore.kernel.org/linux-sunxi/20250307005712.16828-1-andre.przywara@xxxxxxx/T/#t
I'll add that information to the cover letter.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.