Re: [PATCH v2 2/2] arm64: dts: ti: k3-j722s-main: Disable "serdes_wiz0" and "serdes_wiz1"
From: Siddharth Vadapalli
Date: Sat Apr 12 2025 - 01:36:14 EST
On Fri, Apr 11, 2025 at 09:22:00PM +0530, Kumar, Udit wrote:
> Hi
>
> On 4/11/2025 7:47 PM, Siddharth Vadapalli wrote:
> > On Fri, Apr 11, 2025 at 07:31:52PM +0530, Kumar, Udit wrote:
[...]
> > > Since you are disabling parent node.
> > >
> > > Do you still want to carry status = "disabled" in child nodes serdes0 and
> > > serdes1.
> > I could drop it, but then the patches will look something like:
> > 1) Patch 1: Same as the first patch in this series
> > 2) Patch 2: Current patch + Remove status = "disabled" within serdes0/1
> > 3) Patch 3: Removed redundant status = "okay" within serdes0/1 in
> > k3-j722s-evm.dts
> >
> > Updated Patch 2 and the new Patch 3 mentioned above aren't necessarily a
> > complete "Fix" and have other changes in addition to the "Fix". For that
> > reason, the changes associated with the updated patch 2 and the new patch 3
> > could be a separate series, unless you believe that they should go
> > together in the current series. Please let me know.
>
> I don't see any use case where serdes_wiz0 is enabled and serdes0 is
> disabled.
>
> So your comment 3) is valid. you can take this clean up in other series
>
>
> For now
>
> Reviewed-by: Udit Kumar <u-kumar1@xxxxxx>
I have posted the cleanup series at:
https://lore.kernel.org/r/20250412052712.927626-1-s-vadapalli@xxxxxx/
The cleanup series applies on top of the current series.
Regards,
Siddharth.