Re: [PATCH 0/3] Fix up building KUnit tests for Cirrus Logic modules

[David Gow]

On Fri, 11 Apr 2025 at 20:36, Richard Fitzgerald
<rf@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> This series fixes the KConfig for cs_dsp and cs-amp-lib tests so that
> CONFIG_KUNIT_ALL_TESTS doesn't cause them to add modules to the build.
>
> Patch 1 adds the ASoC CS35L56 driver to KUnit all_tests.config so that
>         cs_dsp and cs-amp-lib will be included in the test build.
>
> Patch 2 and 3 fixup the KConfig entries for cs_dsp and cs-amp-lib.

This looks great to me.

The series is:
Reviewed-by: David Gow <davidgow@xxxxxxxxxx>


Do you want us to take this (either the whole thing, or just the first
patch) via the KUnit tree, or will you take it yourself? Either should
work here.

Cheers,
-- David

>
> Nico Pache (1):
>   firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it
>
> Richard Fitzgerald (2):
>   kunit: configs: Add some Cirrus Logic modules to all_tests
>   ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB
>
>  drivers/firmware/cirrus/Kconfig              | 5 +----
>  sound/soc/codecs/Kconfig                     | 5 ++---
>  tools/testing/kunit/configs/all_tests.config | 2 ++
>  3 files changed, 5 insertions(+), 7 deletions(-)
>
> --
> 2.39.5
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature