Re: [PATCH RESEND] kunit: qemu_configs: SH: Respect kunit cmdline

From: David Gow
Date: Sat Apr 12 2025 - 03:02:53 EST


On Mon, 7 Apr 2025 at 16:58, Thomas Weißschuh
<thomas.weissschuh@xxxxxxxxxxxxx> wrote:
>
> The default SH kunit configuration sets CONFIG_CMDLINE_OVERWRITE which
> completely disregards the cmdline passed from the bootloader/QEMU in favor
> of the builtin CONFIG_CMDLINE.
> However the kunit tool needs to pass arguments to the in-kernel kunit core,
> for filters and other runtime parameters.
>
> Enable CONFIG_CMDLINE_EXTEND instead, so kunit arguments are respected.
>
> Fixes: 8110a3cab05e ("kunit: tool: Add support for SH under QEMU")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---

Huh, that's odd.

Anyway, this makes sense as a fix: even if sh eventually decides to do
the sane thing and make this default.

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature