Re: [PATCH 1/3] net: qrtr: Turn QRTR into a bus

[Jonathan Cameron]

On Thu, 10 Apr 2025 12:44:25 +0000
Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> wrote:

> Missed one comment so sending a second reply.
> 
> On 06/04/2025 7:01 pm, Jonathan Cameron wrote:
> > On Sun, 06 Apr 2025 14:07:43 +0000
> > Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> wrote:
> >   
> >> Implement a QRTR bus to allow for creating drivers for individual QRTR
> >> services. With this in place, devices are dynamically registered for QRTR
> >> services as they become available, and drivers for these devices are
> >> matched using service and instance IDs.
> >>
> >> In smd.c, replace all current occurences of qdev with qsdev in order to
> >> distinguish between the newly added QRTR device which represents a QRTR
> >> service with the existing QRTR SMD device which represents the endpoint
> >> through which services are provided.
> >>
> >> Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>  
> > Hi Yassine
> > 
> > Just took a quick look through.
> > 
> > It might make more sense to do this with an auxiliary_bus rather
> > than defining a new bus.  
> 
> I'm not familiar with auxiliary bus, but reading the documentation it 
> seems to me like it's used like MFD where there is a device that has 
> multiple functions, just without the subdevices having physical 
> addresses. QRTR is not really a device but more closely resembles 
> something like PCI or I2C as a communication interface.

Fair enough. If this has real bus like properties then it may make
sense to go with a new explicit bus.

Jonathan