Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`

[Danilo Krummrich]

On Sat, Apr 12, 2025 at 01:59:48PM +0200, Miguel Ojeda wrote:
> On Sat, Apr 12, 2025 at 12:30 PM Christian Schrefl
> <chrisi.schrefl@xxxxxxxxx> wrote:
> >
> > "propper" type for this, so use a `*const kernel::ffi::c_char` pointer
> > instad.
> 
> A couple typos -- I usually suggest using e.g. `scripts/checkpatch.pl
> --codespell`.
> 
> > This should probably be backported to stable, for people/distros
> > using Arm 32 patches on stable.
> 
> Up to the stable team -- I will add Cc: stable when I pick it up since
> it shouldn't hurt, but it does not change anything there for the
> supported arches, so they may or may not want to pick it.

Typically, firmware patches go through driver-core, but if you like I'm fine
with you taking it through the Rust tree.

	Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>

I don't think backporting it hurts, but it's also not really necessary. Like
Miguel says, up to the stable team.

Just note that before v6.13, core::ffi is required, since kernel::ffi does not
exist. The firmware abstractions were introduced with v6.11.

- Danilo