Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING

From: Liam R. Howlett
Date: Sat Apr 12 2025 - 09:18:03 EST


* SeongJae Park <sj@xxxxxxxxxx> [250411 13:47]:
> On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx> wrote:
>
> > MEMORY MAPPING does not list the mmap.h trace point file, but does list
> > the mmap.c file. Couple the trace points with the users and authors of
> > the trace points for notifications of updates.
> >
> > Cc:Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc:Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> > Cc:Vlastimil Babka <vbabka@xxxxxxx>
> > Cc:Jann Horn <jannh@xxxxxxxxxx>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
>
> Aced-by: SeongJae Park <sj@xxxxxxxxxx>
>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15571,6 +15571,7 @@ L: linux-mm@xxxxxxxxx
> > S: Maintained
> > W: http://www.linux-mm.org
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F: include/trace/events/mmap.h
>
> Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
mm/mmap_lock.c, which also isn't listed here. Both exist for tracing as
well.

There is also include/linux/mmap_lock.h, which is the locking itself.
The mmap lock is used more broadly than just these files: mm/pagewalk.c
and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Thanks for bringing this up,
Liam