Re: [PATCH 0/5] gpio: aggregator: Fix Smatch warnings

From: Dan Carpenter
Date: Sat Apr 12 2025 - 12:43:37 EST


On Sat, Apr 12, 2025 at 11:45:08PM +0900, Koichiro Den wrote:
> On Sat, Apr 12, 2025 at 01:14:53PM GMT, Dan Carpenter wrote:
> > Fix some static checker warnings from Smatch:
> > https://github.com/error27/smatch
> >
> > Dan Carpenter (5):
> > gpio: aggregator: fix "_sysfs" prefix check in
> > gpio_aggregator_make_group()
> > gpio: aggregator: Fix gpio_aggregator_line_alloc() checking
> > gpio: aggregator: Return an error if there are no GPIOs in
> > gpio_aggregator_parse()
> > gpio: aggregator: Fix error code in gpio_aggregator_activate()
> > gpio: aggregator: Fix leak in gpio_aggregator_parse()
> >
> > drivers/gpio/gpio-aggregator.c | 21 ++++++++++++---------
> > 1 file changed, 12 insertions(+), 9 deletions(-)
>
> Thank you very much for spotting these issues. I doubt myself for having
> overlooked these.

Heh. Don't beat yourself up. Humans can never compete with a computer
at being nit-picky.

regards,
dan carpenter