Re: [PATCH v4 08/11] x86/sev: Split off startup code from core code
From: Ingo Molnar
Date: Sat Apr 12 2025 - 14:48:59 EST
* Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Ard Biesheuvel <ardb+git@xxxxxxxxxx> wrote:
>
> > From: Ard Biesheuvel <ardb@xxxxxxxxxx>
> >
> > Disentangle the SEV core code and the SEV code that is called during
> > early boot. The latter piece will be moved into startup/ in a subsequent
> > patch.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> > ---
> > arch/x86/boot/compressed/sev.c | 2 +
> > arch/x86/coco/sev/Makefile | 12 +-
> > arch/x86/coco/sev/core.c | 1574 ++++----------------
> > arch/x86/coco/sev/shared.c | 281 ----
> > arch/x86/coco/sev/startup.c | 1395 +++++++++++++++++
> > 5 files changed, 1658 insertions(+), 1606 deletions(-)
>
> x86-64 allmodconfig build failure:
>
> arch/x86/boot/compressed/sev.c:263:13: error: implicit declaration of function ‘vmgexit_psc’ [-Wimplicit-function-declaration]
> | ^~~~~~~~~~~
> arch/x86/boot/compressed/sev.c:266:9: error: implicit declaration of function ‘pvalidate_pages’; did you mean ‘pvalidate_4k_page’? [-Wimplicit-function-declaration]
> | ^~~~~~~~~~~~~~~
> | pvalidate_4k_page
Ignore that, I have now read the cover letter too, with the patch
dependency mentioned there - as kindly pointed out by Ard in a private
mail. :-)
Thanks,
Ingo