Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h

From: Ingo Molnar
Date: Sat Apr 12 2025 - 16:15:44 EST



* Mario Limonciello <superm1@xxxxxxxxxx> wrote:

> SB800 is pre-Zen stuff. It's "before my time" - I guess that's the
> precursor to FCH being in the SoC but has the same functionality.
>
> So I'm thinking <asm/amd_fch.h>.

I went by the SB800_PIIX4_FCH_PM_ADDR name, which is a misnomer these
days?

But yeah, <asm/amd_fch.h> sounds good to me too. Boris?

and ... I'm sure you knew this was coming, but we should probably move
*all* basic FCH_PM definitions into that header, such as
SB800_PIIX4_FCH_PM_SIZE, and rename it to FCH_PM_SIZE or so?

Thanks,

Ingo