Re: [PATCH v4 08/11] x86/sev: Split off startup code from core code

[Ard Biesheuvel]

On Sat, 12 Apr 2025 at 22:08, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> > Ignore that, I have now read the cover letter too, with the patch
> > dependency mentioned there - as kindly pointed out by Ard in a
> > private mail. :-)
>
> But there are other problems during the allmodconfig final link:
>
>   vmlinux.o: warning: objtool: __sev_es_nmi_complete+0x5a: call to __asan_memset() leaves .noinstr.text section

This is an odd one, because noinstr functions should not be
instrumented by kasan afaik.

>   ld: error: unplaced orphan section `.data.rel.local' from `vmlinux.o'

This should have been included in
68f3ea7ee199ef77551e090dfef5a49046ea8443, the commit log has the
details. TL;DR this is .rodata with relocatable quantities, which is
not emitted into .rodata when using -fPIC.

>   make[2]: *** [scripts/Makefile.vmlinux:91: vmlinux.unstripped] Error 1
>
> The objtool warning is caused by:
>
>   x86/sev: Split off startup code from core code
>
> Tte link failure by:
>
>   x86/boot: Move SEV startup code into startup/
>

Thanks for the report - I'll fix these up in the next revision.