Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h

[Ingo Molnar]

* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On April 12, 2025 10:15:27 PM GMT+02:00, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> >* Mario Limonciello <superm1@xxxxxxxxxx> wrote:
> >
> >> SB800 is pre-Zen stuff.  It's "before my time" - I guess that's the 
> >> precursor to FCH being in the SoC but has the same functionality.
> >> 
> >> So I'm thinking <asm/amd_fch.h>.
> >
> >I went by the SB800_PIIX4_FCH_PM_ADDR name, which is a misnomer these 
> >days?
> >
> >But yeah, <asm/amd_fch.h> sounds good to me too. Boris?
> 
> I was aiming more for a header which contains non-CPU defines - i.e., 
> platform. But the FCH is only one part of that platform. But let's 
> start with amd/fch.h - "amd/" subpath element would allow us to 
> trivially put other headers there too - and see where it gets us. We 
> can (and will) always refactor later if needed...

Yeah, agreed on opening the <asm/amd/> namespace for this.

Thanks,

	Ingo