Re: [PATCH] iio: normalize array sentinel style

From: Jonathan Cameron
Date: Sun Apr 13 2025 - 05:40:10 EST


On Sat, 12 Apr 2025 15:55:35 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Fri, Apr 11, 2025 at 11:50 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> >
> > Use `\t(\{ ?\},|\{\}|\{\s*/\*.*\*/\s*\},?)$` regex to find and replace
> > the array sentinel in all IIO drivers to the same style.
> >
> > For some time, we've been trying to consistently use `{ }` (no trailing
> > comma, no comment, one space between braces) for array sentinels in the
> > IIO subsystem. Still nearly 50% of existing code uses a different style.
> > To save reviewers from having to request this trivial change as
> > frequently, let's normalize the style in all existing IIO drivers.
> > At least when code is copy/pasted to new drivers, the style will be
> > consistent.
>
> With or without iiner space, but same style. What is important is that
> you removed the trailing commas.
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
>
Agreed. The space thing was a random choice, but consistency is good
and comma part matters more.

Applied. One case had already gone away in my tree and there was a little
fuzz but should all be fine.

Thanks,

Jonathan