Re: [PATCH v2 02/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgenc compatible
From: Kyrie Wu (吴晗)
Date: Sun Apr 13 2025 - 05:56:51 EST
On Sat, 2025-04-12 at 12:13 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 11/04/2025 04:48, Kyrie Wu (吴晗) wrote:
> > On Thu, 2025-04-10 at 08:40 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > >
> > >
> > > On Thu, Apr 10, 2025 at 02:29:55PM GMT, kyrie.wu wrote:
> > > > Add mediatek,mt8196-jpgenc compatible to binding document.
> > > >
> > > > Signed-off-by: kyrie.wu <kyrie.wu@xxxxxxxxxxxx>
> > >
> > > Same comments.
> > >
> > > Also: missing media prefix in subject.
> > >
> > > Please use subject prefixes matching the subsystem. You can get
> > > them
> > > for
> > > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the
> > > directory
> > > your patch is touching. For bindings, the preferred subjects are
> > > explained here:
> > >
> >
> >
https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html*i-for-patch-submitters__;Iw!!CTRNKA9wMg0ARbw!lYnGLcOBQIh9yQUyMcteKxvcKQv2_eSc4udxkDDWXikTyN8VcXyYDgGuK-8UZWxKE5Pmg3D5lvplcw$
> > >
> > > Best regards,
> > > Krzysztof
> > >
> >
> > Dear Krzysztof,
> >
> > Thanks for your comment. I will change subject in the next version
> > like following:
> >
> > dt-bindings: media: mediatek,jpeg: xxx
>
> Did you even read the link I provided? How can I be more specific?
>
> Best regards,
> Krzysztof
Dear Krzysztof,
I'm terriably to bother you again.
I used the cmd of 'git log --oneline --
Documentation/devicetree/bindings/media/', the below string were got:
...
dt-bindings: media: mediatek,jpeg: Relax IOMMU max item count
...
But these contents are shown from the link you supplied:
Few subsystems, like ASoC, media, regulators and SPI, expect reverse
order of the prefixes:
"<binding dir>: dt-bindings: ..."
The two results are different. Which do I need to take to fix my patch
in the next version?
Thanks.
Regards,
Kyrie.