Re: [PATCH v1] ptp: ocp: add irig and dcf NULL-check in __handle_signal functions
From: Sagi Maimon
Date: Sun Apr 13 2025 - 09:44:46 EST
HI Paolo
Most of your notes are clear and will be fixed.
can you explain more regarding: "And you should specify the target
tree in the subj prefix"
Did you mean: net, net-next, Linux-nex?
On Thu, Apr 10, 2025 at 1:23 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On 4/9/25 11:24 AM, Sagi Maimon wrote:
> > In __handle_signal_outputs and __handle_signal_inputs add
> > irig and dcf NULL-check
>
> You need to expand a little the commit message. Is the NULL ptr
> dereference actually possible? How? or this is just defensive programming?
>
> If there is a real NULL ptr dereference this need a suitable Fixes tag.
>
> And you should specify the target tree in the subj prefix.
>
> You can retain the collected ack when resubmitting.
>
> Thanks,
>
> Paolo
>