Re: [PATCH v6] iio: frequency: ad9832: Use FIELD_PREP macro to set bit fields

From: Marcelo Schmitt
Date: Sun Apr 13 2025 - 13:44:06 EST


On 04/13, Siddharth Menon wrote:
> Use bitfield and bitmask macros to clearly specify AD9832 SPI
> command fields to make register write code more readable.
>
> Suggested-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>
> Signed-off-by: Siddharth Menon <simeddon@xxxxxxxxx>
> ---
> The error path for AD9832_FREQ_SYM was not removed as initially
> suggested by Marcelo, since he changed his mind, considering it
> would not follow the proposed ABI

Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>

Regards,
Marcelo