Re: [tip: core/urgent] compiler.h: Avoid the usage of __typeof_unqual__() when __GENKSYMS__ is defined

From: Uros Bizjak
Date: Sun Apr 13 2025 - 15:28:26 EST


On Sun, Apr 13, 2025 at 9:20 PM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Uros Bizjak <ubizjak@xxxxxxxxx> wrote:
>
> > > > If this commit is removed, [...]
> > >
> > > I did not remove commit ac053946f5c4, it's already upstream. Nor
> > > did I advocate for it to be reverted - I'd like it to be fixed. So
> > > you are barking up the wrong tree.
> >
> > If the intention is to pass my proposed workaround via Andrew's tree,
> > then I'm happy to bark up the wrong tree, but from the referred
> > message trail, I didn't get the clear decision about the patch, and
> > neither am sure which patch "brown paper bag bug" refers to.
>
> It's up to akpm (he merged your original patch that regressed), but I
> think scripts/genksyms/ should be fixed instead of worked around -
> which is why I zapped the workaround.

As said earlier, I have tried to fix genksyms, but the simple fix was
not enough. The correct fix would be somehow more involved, and I have
zero experience in genksyms source. I'm afraid I don't know this
source well enough to offer a fix in the foreseeable future, so I
resorted to the workaround (which at the end of the day is as
effective as the real fix).

Regards,
Uros.