Re: [PATCH v2 0/4] hisi_sas: Misc patches and cleanups

[Yihang Li]

I will check and fix, thanks for reminder.

Thanks,
Yihang

On 2025/4/12 8:45, Martin K. Petersen wrote:
> 
> Hi Yihang!
> 
>> This series contains some minor bugfix and general tidying:
>> - Ignore the soft reset result by calling I_T_nexus after the SATA disk
>>   is soft reset
>> - General minor tidying
> 
> v3_hw won't compile after applying this series:
> 
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_show_row_64_v3_hw’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3718:27: error: ‘TWO_PARA_PER_LINE’ undeclared (first use in this function)
>  3718 |                 if (!(i % TWO_PARA_PER_LINE))
>       |                           ^~~~~~~~~~~~~~~~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3718:27: note: each undeclared identifier is reported only once for each function it appears in
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_show_row_32_v3_hw’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3734:27: error: ‘FOUR_PARA_PER_LINE’ undeclared (first use in this function)
>  3734 |                 if (!(i % FOUR_PARA_PER_LINE))
>       |                           ^~~~~~~~~~~~~~~~~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_create_files_v3_hw’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3896:19: error: ‘NAME_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
>  3896 |         char name[NAME_BUF_SIZE];
>       |                   ^~~~~~~~~~~~~
>       |                   PROT_BUF_SIZE
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3896:14: error: unused variable ‘name’ [-Werror=unused-variable]
>  3896 |         char name[NAME_BUF_SIZE];
>       |              ^~~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_trigger_dump_v3_hw_write’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3974:18: error: ‘DUMP_BUF_SIZE’ undeclared (first use in this function); did you mean ‘DUMMY_BUF_SIZE’?
>  3974 |         char buf[DUMP_BUF_SIZE];
>       |                  ^~~~~~~~~~~~~
>       |                  DUMMY_BUF_SIZE
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3974:14: error: unused variable ‘buf’ [-Werror=unused-variable]
>  3974 |         char buf[DUMP_BUF_SIZE];
>       |              ^~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_bist_linkrate_v3_hw_write’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4040:19: error: ‘BIST_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
>  4040 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
>       |                   ^~~~~~~~~~~~~
>       |                   PROT_BUF_SIZE
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4040:14: error: unused variable ‘kbuf’ [-Werror=unused-variable]
>  4040 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
>       |              ^~~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_bist_code_mode_v3_hw_write’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4115:19: error: ‘BIST_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
>  4115 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
>       |                   ^~~~~~~~~~~~~
>       |                   PROT_BUF_SIZE
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4115:14: error: unused variable ‘kbuf’ [-Werror=unused-variable]
>  4115 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
>       |              ^~~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_bist_mode_v3_hw_write’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4247:19: error: ‘BIST_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
>  4247 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
>       |                   ^~~~~~~~~~~~~
>       |                   PROT_BUF_SIZE
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4247:14: error: unused variable ‘kbuf’ [-Werror=unused-variable]
>  4247 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
>       |              ^~~~
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_phy_down_cnt_init_v3_hw’:
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4794:19: error: ‘NAME_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
>  4794 |         char name[NAME_BUF_SIZE];
>       |                   ^~~~~~~~~~~~~
>       |                   PROT_BUF_SIZE
> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4794:14: error: unused variable ‘name’ [-Werror=unused-variable]
>  4794 |         char name[NAME_BUF_SIZE];
>       |              ^~~~
> cc1: all warnings being treated as errors
> 
> Please fix, thanks!
>