Re: [PATCH] genksyms: Handle typeof_unqual keyword and __seg_{fs,gs} qualifiers

[Ingo Molnar]

* Uros Bizjak <ubizjak@xxxxxxxxx> wrote:

> On Mon, Apr 14, 2025 at 9:20 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> >
> > * Uros Bizjak <ubizjak@xxxxxxxxx> wrote:
> >
> > > Handle typeof_unqual, __typeof_unqual and __typeof_unqual__ keywords
> > > using TYPEOF_KEYW token in the same way as typeof keyword.
> > >
> > > Also ignore x86 __seg_fs and __seg_gs named address space qualifiers
> > > using X86_SEG_KEYW token in the same way as const, volatile or
> > > restrict qualifiers.
> > >
> > > Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> > > Reported-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> > > Closes: https://lore.kernel.org/lkml/81a25a60-de78-43fb-b56a-131151e1c035@xxxxxxxxxxxxx/
> > > Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > > ---
> > >  scripts/genksyms/keywords.c | 7 +++++++
> > >  scripts/genksyms/parse.y    | 5 ++++-
> > >  2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > Thanks, applied to tip:core/urgent.
> >
> > I've also added this tag for context:
> >
> >   Fixes: ac053946f5c4 ("compiler.h: introduce TYPEOF_UNQUAL() macro")
> 
> Heh, I intentionally removed it because the patch now fixes genksyms.

There's meritocratical value in generously accepting blame, even if you 
are only 10% to blame. ;-)

	Ingo