Re: [PATCH] drm: Select DRM_KMS_HELPER from DRM_DEBUG_DP_MST_TOPOLOGY_REFS

[Janne Grunau]

Hej,

On Tue, Mar 04, 2025 at 08:12:14PM +0100, Janne Grunau via B4 Relay wrote:
> From: Janne Grunau <j@xxxxxxxxxx>
> 
> Using "depends on" and "select" for the same Kconfig symbol is known to
> cause circular dependencies (cmp. "Kconfig recursive dependency
> limitations" in Documentation/kbuild/kconfig-language.rst.
> DRM drivers are selecting drm helpers so do the same for
> DRM_DEBUG_DP_MST_TOPOLOGY_REFS.
> Fixes following circular dependency reported on x86 for the downstream
> Asahi Linux tree:
> 
> error: recursive dependency detected!
>   symbol DRM_KMS_HELPER is selected by DRM_GEM_SHMEM_HELPER
>   symbol DRM_GEM_SHMEM_HELPER is selected by RUST_DRM_GEM_SHMEM_HELPER
>   symbol RUST_DRM_GEM_SHMEM_HELPER is selected by DRM_ASAHI
>   symbol DRM_ASAHI depends on RUST
>   symbol RUST depends on CALL_PADDING
>   symbol CALL_PADDING depends on OBJTOOL
>   symbol OBJTOOL is selected by STACK_VALIDATION
>   symbol STACK_VALIDATION depends on UNWINDER_FRAME_POINTER
>   symbol UNWINDER_FRAME_POINTER is part of choice block at arch/x86/Kconfig.debug:224
>   symbol <choice> unknown is visible depending on UNWINDER_GUESS
>   symbol UNWINDER_GUESS prompt is visible depending on STACKDEPOT
>   symbol STACKDEPOT is selected by DRM_DEBUG_DP_MST_TOPOLOGY_REFS
>   symbol DRM_DEBUG_DP_MST_TOPOLOGY_REFS depends on DRM_KMS_HELPER
> 
> Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index fbef3f471bd0e5101699cf576542f7350bea3982..bd228dc77e99b4356b09de02d9001237eb2423e2 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -188,7 +188,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS
>          bool "Enable refcount backtrace history in the DP MST helpers"
>  	depends on STACKTRACE_SUPPORT
>          select STACKDEPOT
> -        depends on DRM_KMS_HELPER
> +        select DRM_KMS_HELPER
>          depends on DEBUG_KERNEL
>          depends on EXPERT
>          help
> 

Can this change be merged? I do not see it in v6.15-rc1.

thanks
Janne