Re: [PATCH v2 5/5] ALSA: korg1212: snd_korg1212_prepare: Rename del_timer in comment

[Philipp Stanner]

On Mon, 2025-04-14 at 12:26 +0800, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to
> timer_delete[_sync]()")
> switched del_timer to timer_delete, but did not modify the comment
> for
> snd_korg1212_prepare(). Now fix it.
> 
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Philipp Stanner <pstanner@xxxxxxxxxx>
> Cc: SOUND <linux-sound@xxxxxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx>
> ---
>  sound/pci/korg1212/korg1212.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/korg1212/korg1212.c
> b/sound/pci/korg1212/korg1212.c
> index 49b71082c485..5e69bb25d420 100644
> --- a/sound/pci/korg1212/korg1212.c
> +++ b/sound/pci/korg1212/korg1212.c
> @@ -1553,7 +1553,7 @@ static int snd_korg1212_prepare(struct
> snd_pcm_substream *substream)
>  		return -EAGAIN;
>  		/*
>  		korg1212->sharedBufferPtr->cardCommand = 0;
> -		del_timer(&korg1212->timer);
> +		timer_delete(&korg1212->timer);
>  		korg1212->stop_pending_cnt = 0;
>  		*/

Wouldn't it be better to just remove all that? Or at least document
what it is good for?


P.


>  	}