Re: [PATCH RFC v5 1/8] media: qcom: iris: move sm8250 to gen1 catalog

[Dmitry Baryshkov]

On 14/04/2025 12:07, Neil Armstrong wrote:
> On 14/04/2025 09:39, Dmitry Baryshkov wrote:
> > On Fri, Apr 11, 2025 at 10:14:02AM +0200, Neil Armstrong wrote:
> > > On 10/04/2025 21:44, Dmitry Baryshkov wrote:
> > > > On Thu, Apr 10, 2025 at 06:30:00PM +0200, Neil Armstrong wrote:
> > > > > Re-organize the platform support core into a gen1 catalog C file
> > > > > declaring common platform structure and include platform headers
> > > > > containing platform specific entries and iris_platform_data
> > > > > structure.
> > > > >
> > > > > The goal is to share most of the structure while having
> > > > > clear and separate per-SoC catalog files.
> > > > >
> > > > > The organization is based on the current drm/msm dpu1 catalog
> > > > > entries.
> > > > >
> > > > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > > > ---
> > > > >    drivers/media/platform/qcom/iris/Makefile          |  2 +-
> > > > >    .../media/platform/qcom/iris/iris_catalog_gen1.c   | 83 ++++++++ 
> > > > > ++++++++++++++
> > > > >    ...ris_platform_sm8250.c => iris_catalog_sm8250.h} | 80 + 
> > > > > +-------------------
> > > >
> > > > I'd suggest _not_ to follow DPU here. I like the per-generation files,
> > > > but please consider keeping platform files as separate C files too.
> > >
> > > This would duplicate all tables, do we really want this ?
> >
> > No. Keep the tables that are shared in iris_catalog_gen1.c, keep
> > platform data in iris_catalog_sm8250.c and iris_catalog_sm8550.c (and
> > later iris_catalog_sm8650.c)
>
> This won't work, we need ARRAY_SIZE() for most of the tables

I see. Can you do it other way around: export platform-specific data 
from the iris_catalog_sm8250.c and use it inside iris_catalog_gen1.c?

> Neil
>
> > > I want just to add SM8650 support, not to entirely rework the
> > > whole iris driver.
> > >
> > > Neil
> > >
> > > > >    3 files changed, 89 insertions(+), 76 deletions(-)


--
With best wishes
Dmitry