Re: [PATCH net-next 6/7] ice: Don't use %pK through printk or tracepoints

From: Przemek Kitszel
Date: Mon Apr 14 2025 - 06:00:08 EST


On 4/14/25 10:26, Thomas Weißschuh wrote:
In the past %pK was preferable to %p as it would not leak raw pointer
values into the kernel log.
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
the regular %p has been improved to avoid this issue.
Furthermore, restricted pointers ("%pK") were never meant to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping looks in atomic contexts.

Switch to the regular pointer formatting which is safer and
easier to reason about.
There are still a few users of %pK left, but these use it through seq_file,
for which its usage is safe.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
thank you!
Acked-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>