Re: [PATCH v2] arm64: dts: mediatek: mt7988a-bpi-r4: allow hw variants of bpi-r4

[Frank Wunderlich]

Am 14. April 2025 11:27:23 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>:
>Il 12/04/25 12:21, Frank Wunderlich ha scritto:
>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>> 
snip
>This should at least have some different compatible, if not probably also a
>different model string - as it's a different device.
>
>	compatible = "bananapi,bpi-r4-2g5", "bananapi,bpi-r4", "mediatek,mt7988a";
>	model = "Banana Pi BPI-R4 (2.5GbE)";
>	chassis-type = "embedded";
>
>..snip..
>
>a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi
>> new file mode 100644
>> index 000000000000..1ab09ed2f151
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi
>> @@ -0,0 +1,403 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/regulator/richtek,rt5190a-regulator.h>
>> +
>> +#include "mt7988a.dtsi"
>> +
>> +/ {
>> +	compatible = "bananapi,bpi-r4", "mediatek,mt7988a";
>> +	model = "Banana Pi BPI-R4";
>> +	chassis-type = "embedded";
>
>Please keep compatible/model/chassis-type in dts files.

Ok, should i add specific compatible to existing board (like 2sfp)? Just thinking how binding should look like.

Else is there an example for adding optional compatible without adding a complete block in binding?

>Cheers,
>Angelo


regards Frank