Re: [PATCH v4 2/3] i3c: master: Add Qualcomm I3C controller driver

[Mukesh Kumar Savaliya]

On 4/14/2025 3:38 PM, Konrad Dybcio wrote:
> On 4/14/25 10:53 AM, Mukesh Kumar Savaliya wrote:
> > Hi Konrad, responding to one comment which is not working as suggested by you.
> >
> > On 4/12/2025 4:45 AM, Konrad Dybcio wrote:
> > > On 4/11/25 1:35 PM, Mukesh Kumar Savaliya wrote:
> > > > Add support for the Qualcomm I3C controller driver, which implements
> > > > I3C master functionality as defined in the MIPI Alliance Specification
> > > > for I3C, Version 1.0.
> > > >
> > > > This driver supports master role in SDR mode.
> > > >
> > > > Unlike some other I3C master controllers, this implementation
> > > > does not support In-Band Interrupts (IBI) and Hot-join requests.
> > > >
> > > > Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> > > > ---
>
> [...]
>
> > > > +    if ((m_stat &
> > > > +        (M_RX_FIFO_WATERMARK_EN | M_RX_FIFO_LAST_EN)) &&
> > > > +        !gi3c->cur_is_write && gi3c->cur_buf) {
> > >
> > > The indentation here is confusing, please align the `(M_RX..` with `m_stat &`
> > I have tried to implement this, but always giving me warning as below.
> > Tried many ways, but same issue, hence keeping it like this.
> > In fact, earlier also i faced same issue hence i wrote it this way.
> >
> > CHECK: Alignment should match open parenthesis
> > #468: FILE: drivers/i3c/master/i3c-qcom-geni.c:405:
> > +       if ((m_stat & (M_RX_FIFO_WATERMARK_EN | M_RX_FIFO_LAST_EN)) &&
>
>
> Maybe let's define something like
>
> bool hw_pending_read = m_stat & M_RX...
Sure, that would do. Will update in V5.
> Konrad