Re: [PATCH v8 6/6] rust: enable `clippy::ref_as_ptr` lint

From: Benno Lossin
Date: Mon Apr 14 2025 - 06:53:21 EST


On Wed Apr 9, 2025 at 4:47 PM CEST, Tamir Duberstein wrote:
> In Rust 1.78.0, Clippy introduced the `ref_as_ptr` lint [1]:
>
>> Using `as` casts may result in silently changing mutability or type.
>
> While this doesn't eliminate unchecked `as` conversions, it makes such
> conversions easier to scrutinize. It also has the slight benefit of
> removing a degree of freedom on which to bikeshed. Thus apply the
> changes and enable the lint -- no functional change intended.
>
> Link: https://rust-lang.github.io/rust-clippy/master/index.html#ref_as_ptr [1]
> Suggested-by: Benno Lossin <benno.lossin@xxxxxxxxx>
> Link: https://lore.kernel.org/all/D8PGG7NTWB6U.3SS3A5LN4XWMN@xxxxxxxxx/
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>

Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx>

---
Cheers,
Benno

> ---
> Makefile | 1 +
> rust/bindings/lib.rs | 1 +
> rust/kernel/device_id.rs | 3 ++-
> rust/kernel/fs/file.rs | 3 ++-
> rust/kernel/str.rs | 6 ++++--
> rust/kernel/uaccess.rs | 10 ++++------
> rust/uapi/lib.rs | 1 +
> 7 files changed, 15 insertions(+), 10 deletions(-)