Re: [RFC 5/5] arm64: dts: mediatek: mt7988: Add xsphy for ssusb0/pcie2

[Frank Wunderlich]

Am 14. April 2025 12:27:30 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>:
>Il 13/04/25 10:58, Frank Wunderlich ha scritto:
>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

>> +		xs-phy@11e10000 {
>
>That shall be just "phy@addr"

Ok

>> +			compatible = "mediatek,mt7988-xsphy",
>> +				     "mediatek,xsphy";
>> +			#address-cells = <2>;
>> +			#size-cells = <2>;
>> +			ranges;
>> +			status = "disabled";
>> +
>> +			xphyu2port0: usb-phy@11e10000 {
>
>Perhaps just u2port0/u3port0 like done on the other MediaTek SoC DTs is better
>for consistency :-)

Mt7988 also have a tphy where we have it named tphyu3port. Leaving this imho would increase confusion.

>Cheers!
>


regards Frank