Re: [PATCH RFC net 1/2] net: bridge: switchdev: do not notify new brentries as changed

From: Vladimir Oltean
Date: Mon Apr 14 2025 - 08:59:24 EST


On Mon, Apr 14, 2025 at 02:11:18PM +0200, Jonas Gorski wrote:
> On Mon, Apr 14, 2025 at 1:39 PM Vladimir Oltean <vladimir.oltean@xxxxxxx> wrote:
> > > $ ip link add swbridge type bridge vlan_filtering 1 vlan_default_pvid 1
>
> as mentioned for the cover letter, I will fix the example to use
> default_pvid 0 to have a "working" example.

Please do so. You have consistently given examples with vlan_default_pvid 1
throughout the patch set.

> Will add it. And I did check that, even considered shortly to merge this to
>
> if (becomes_brentry || would_change)
> *changed = true;
>
> but then considered that a refactoring too much.

I agree that it would be an unnecessary change for 'net'. You can send a
refactoring patch for net-next after Thursday, though.