Re: [PATCH] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

[Tamir Duberstein]

On Mon, Apr 14, 2025 at 5:02 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> On Mon, 14 Apr 2025 at 10:50, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > Enabling a (modular) test should not silently enable additional kernel
> > functionality, as that may increase the attack vector of a product.
> >
> > Fix this by making PRIME_NUMBERS_KUNIT_TEST depend on PRIME_NUMBERS
> > instead of selecting it.
> >
> > After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to build
> > modules for all appropriate tests for ones system, without pulling in
> > extra unwanted functionality, while still allowing a tester to manually
> > enable PRIME_NUMBERS and this test suite on a system where PRIME_NUMBERS
> > is not enabled by default.
> >
> > Fixes: 313b38a6ecb46db4 ("lib/prime_numbers: convert self-test to KUnit")
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Acked-by: Tamir Duberstein <tamird@xxxxxxxxx>