Re: [PATCH v2] rust: check type of `$ptr` in `container_of!`

[Miguel Ojeda]

On Mon, Apr 14, 2025 at 3:27 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>
> `b4 prep --check` complains:
>   ● checkpatch.pl: :207: ERROR: Avoid using diff content in the commit
> message - patch(1) might not work
>
> What do you suggest?

(It is `checkpatch.pl` the one that complains, no?)

I don't think it really matters, since `git am` is OK with it. So
unless you are sending the patch to a subsystem that still uses
`patch` or `quilt` or similar, and those are quite rare nowadays, I
wouldn't worry.

But if you care and want to be extra nice, then I would suggest doing
what others do, i.e. checking the Git log. That tells me to use `>` or
`:`, since they seem to be common. I don't see `;`.

I would also recommend patching `patch`... :)

Thanks for clarifying!

Cheers,
Miguel