Re: [PATCH v2 net] net: ngbe: fix memory leak in ngbe_probe() error path

[Kory Maincent]

On Sat, 12 Apr 2025 21:19:24 +0530
Abdun Nihaal <abdun.nihaal@xxxxxxxxx> wrote:

> When ngbe_sw_init() is called, memory is allocated for wx->rss_key
> in wx_init_rss_key(). However, in ngbe_probe() function, the subsequent
> error paths after ngbe_sw_init() don't free the rss_key. Fix that by
> freeing it in error path along with wx->mac_table.
> 
> Also change the label to which execution jumps when ngbe_sw_init()
> fails, because otherwise, it could lead to a double free for rss_key,
> when the mac_table allocation fails in wx_sw_init().
> 
> Fixes: 02338c484ab6 ("net: ngbe: Initialize sw info and register netdev")
> Signed-off-by: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>

legit!

Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>

Thank you!
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com