Re: [PATCH] tpm_crb: ffa_tpm: return errors from interface functions if no ffa-crb driver
From: Sudeep Holla
Date: Mon Apr 14 2025 - 11:35:16 EST
On Mon, Apr 14, 2025 at 09:52:35AM -0500, Stuart Yoder wrote:
> If ACPI advertises an FF-A based TPM but the tpm_crb_ffa driver is not
> enabled via Kconfig, inline stub versions of the interface functions
> are used. These functions incorrectly return 0, which indicates success.
> The result is that the tpm_crb probe function continues execution and
> eventually detects a timeout at the TPM.
>
> Change the inline functions to return errors, so that probe() sees that
> tpm_crb_ffa is not present and aborts the probe.
>
LGTM,
Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>
--
Regards,
Sudeep